-
-
Notifications
You must be signed in to change notification settings - Fork 639
chore(toolchain): remove chmod and disable ignore_root_error #3421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aignas
wants to merge
16
commits into
bazel-contrib:main
Choose a base branch
from
aignas:aignas.chore.remove-root-error-and-chmod
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
chore(toolchain): remove chmod and disable ignore_root_error #3421
aignas
wants to merge
16
commits into
bazel-contrib:main
from
aignas:aignas.chore.remove-root-error-and-chmod
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s and use our shell script to update deleted pkgs
aignas
added a commit
to aignas/rules_python
that referenced
this pull request
Nov 22, 2025
Summary: - Before this we were relying on an upstream script, but because how we are building our docs we need to customize how it is working. - What is more, the format was hard to maintain and prone to human errors. Split out of bazel-contrib#3421
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE: stacked on #3425
As discussed in the #2024 messaged we decided to remove the chmoding and
simplify the setup for all of our users. This in effect unifies how the
toolchains are created across all of the platforms reducing the need for some
of the integration tests.
Summary:
python_repository: stop chmodingpython_repository: makeignore_root_user_errornooppython(bzlmod): stop usingignore_root_user_error.tests: removeignore_root_user_errortests.Fixes #2016
Fixes #2053
Closes #2024